Enable splitting qkv and gate_up #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chendi Xue <[email protected]>
tianmu-li
requested review from
kzawora-intel,
madamczykhabana,
michalkuligowski and
mgawarkiewicz
as code owners
szutenberg
pushed a commit
that referenced
this pull request
Jan 16, 2025
Enable splitting qkv and gate_up into separate columnparallellinear layers, instead of overwriting qkvparallellinear and mergedcolumnparallellinear layers. --------- Signed-off-by: Chendi Xue <[email protected]> Co-authored-by: Kunshang Ji <[email protected]> Co-authored-by: Chendi Xue <[email protected]> Co-authored-by: Barak Goldberg <[email protected]> Co-authored-by: Nir David <[email protected]>
xuechendi
added a commit
that referenced
this pull request
Jan 22, 2025
Enable splitting qkv and gate_up into separate columnparallellinear layers, instead of overwriting qkvparallellinear and mergedcolumnparallellinear layers. --------- Signed-off-by: Chendi Xue <[email protected]> Co-authored-by: Kunshang Ji <[email protected]> Co-authored-by: Chendi Xue <[email protected]> Co-authored-by: Barak Goldberg <[email protected]> Co-authored-by: Nir David <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable splitting qkv and gate_up into separate columnparallellinear layers, instead of overwriting qkvparallellinear and mergedcolumnparallellinear layers.